Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.71.1 update #2339

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Rust 1.71.1 update #2339

merged 1 commit into from
Aug 5, 2023

Conversation

Licenser
Copy link
Member

Description

Rust update

Checklist

  • The RFC, if required, has been submitted and approved
  • Any user-facing impact of the changes is reflected in docs.tremor.rs
  • The code is tested
  • Use of unsafe code is reasoned about in a comment
  • Update CHANGELOG.md appropriately, recording any changes, bug fixes, or other observable changes in behavior
  • The performance impact of the change is measured (see below)

Performance

-/-

@Licenser Licenser enabled auto-merge (rebase) July 21, 2023 11:00
@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #2339 (aac7c6e) into main (48ba0e2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2339      +/-   ##
==========================================
+ Coverage   91.10%   91.11%   +0.01%     
==========================================
  Files         275      274       -1     
  Lines       58236    58233       -3     
==========================================
+ Hits        53053    53057       +4     
+ Misses       5183     5176       -7
Flag Coverage Δ
unittests 91.11% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/codec/json.rs 89.23% <100.00%> (ø)
src/connectors/impls/gpubsub/consumer.rs 92.60% <100.00%> (+0.70%) ⬆️
src/connectors/impls/gpubsub/producer.rs 98.05% <100.00%> (ø)
src/connectors/sink/channel_sink.rs 85.05% <100.00%> (ø)
src/connectors/utils/url.rs 83.90% <100.00%> (ø)
tremor-common/src/ids.rs 70.00% <100.00%> (ø)
tremor-script/src/ast/deploy/raw.rs 84.87% <100.00%> (ø)
tremor-script/src/ast/raw.rs 93.41% <100.00%> (ø)

... and 13 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ba0e2...aac7c6e. Read the comment docs.

@Licenser
Rust 1.71.1 update
aac7c6e 
Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser Licenser changed the title Rust 1.71.0 update Rust 1.71.1 update Aug 5, 2023
darach
darach approved these changes Aug 5, 2023
View reviewed changes
Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Licenser Licenser merged commit 20c76b7 into main Aug 5, 2023
18 checks passed
@Licenser Licenser deleted the rust-1.71.0 branch August 5, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darach darach darach approved these changes

@mfelsche mfelsche Awaiting requested review from mfelsche mfelsche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Licenser @darach